Skip to content

8384066: [lworld] TestDeadAllocationRemoval.java is ignored by jtreg#2404

Open
xmas92 wants to merge 1 commit into
openjdk:lworldfrom
xmas92:lworld-bad-jterg-TestDeadAllocationRemoval
Open

8384066: [lworld] TestDeadAllocationRemoval.java is ignored by jtreg#2404
xmas92 wants to merge 1 commit into
openjdk:lworldfrom
xmas92:lworld-bad-jterg-TestDeadAllocationRemoval

Conversation

@xmas92
Copy link
Copy Markdown
Member

@xmas92 xmas92 commented May 7, 2026

TestDeadAllocationRemoval.java is missing the @test annotation in its comment and is ignored by jtreg. The test also refers to a nonexistent class, why is probably an uncaught typo caused by the test not actually being ran.



Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JDK-8384066: [lworld] TestDeadAllocationRemoval.java is ignored by jtreg (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/2404/head:pull/2404
$ git checkout pull/2404

Update a local copy of the PR:
$ git checkout pull/2404
$ git pull https://git.openjdk.org/valhalla.git pull/2404/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2404

View PR using the GUI difftool:
$ git pr show -t 2404

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/2404.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper Bot commented May 7, 2026

👋 Welcome back aboldtch! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 7, 2026

@xmas92 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8384066: [lworld] TestDeadAllocationRemoval.java is ignored by jtreg

Reviewed-by: thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the lworld branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@openjdk openjdk Bot added the rfr Pull request is ready for review label May 7, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge Bot commented May 7, 2026

Webrevs

Copy link
Copy Markdown
Member

@TobiHartmann TobiHartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@openjdk openjdk Bot added the ready Pull request is ready to be integrated label May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants